Update README claims of LLVM support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vtjnash
approved these changes
May 11, 2021
|
Do you have any opinion on what to do about the ifdefs? |
|
I've typically stayed with a version until someone makes a PR to update, with the intent of only supporting one LLVM version, with that version being the newest that someone was able to get building and working. |
|
But, per the linked issue, I haven't made that official, and so far have let ifdef's exist for a couple versions. |
|
Thanks for the response. I guess there's no need to close that door right now. Maybe if a future LLVM version makes things painful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #119 and #91.
Relevant to #60, but does not implement it. As a practical matter: I am using LLVM 10 right now, there probably isn't full LLVM 11 support, and the latest version of LLVM is 12 which doesn't work yet (#116).
Btw, I'm also wondering if we should remove the ifdef's for 9 and below.